cda-37 Store blobs in object-store #1519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
still lots to cleanup and reorganize |
MikeNeilson
reviewed
Dec 23, 2025
Contributor
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Seems reasonable so far.
rma-rripken
force-pushed
the
feature/cda-37-s3_blob_and_clob
branch
from
4da44e9 to
d02ccfe
Compare
…nd Content-Length headers instead.
…reManagerProvider.
Collaborator
Author
|
I think I've implemented all the blob parts. Would need to follow up with a similar clob dao that handles text encoding. |
MikeNeilson
requested changes
Jan 16, 2026
Contributor
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Overall looks good. A few nitpicks and probably at least one just misunderstanding of togglz on my part I need clarified.
| private BlobAccess chooseBlobAccess(DSLContext dsl) { | ||
| boolean useObjectStore = isObjectStorageEnabled(); | ||
| try { | ||
| // Prefer Togglz if available |
Contributor
There was a problem hiding this comment.
why wouldn't it be available?
| return new BlobDao(dsl); | ||
| } | ||
|
|
||
| private boolean isObjectStorageEnabled() { |
Contributor
There was a problem hiding this comment.
Shouldn't this just use the CdaFeatures thing?
| .assertThat() | ||
| .statusCode(is(HttpServletResponse.SC_OK)) | ||
| .header("Transfer-Encoding", equalTo("chunked")) | ||
| // .header("Transfer-Encoding", equalTo("chunked")) |
| } | ||
| } | ||
|
|
||
| private static void setupMinioResources() { |
Contributor
There was a problem hiding this comment.
- This should just be in the Cda Setup extension and can just be started whenever, eventually it'll be the only option and it doesn't really get in the way just being on.
- https://testcontainers.com/modules/minio/ (favor the testcontainer helper modules unless you have reason not to, we do our own for CWMS to make the CWMS setup easier to handle.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.